Sider Code Review Meetup #4 Report

  • Post author:
  • Post last modified:2020-11-25
  • Post category:Code Review
  • Reading time:4 mins read

On September 27th, Sider hosted our fourth Code Review Meetup at Open Network Space by Open Network Lab in Daikayanyama, Tokyo. More than 30 people attended and enjoyed sessions about code reviews presented by four speakers.

Koichi Ito (@koic) from Eiwa System Management, Inc., the first speaker of the night and a RuboCop committer, gave a talk titled For Whom the Quality Exists (slide: https://speakerdeck.com/koic/for-whom-the-quality-exists).

In this Hemingway-like titled talk, Koichi shared his views on how to contribute to a project that involves various people with different background. He explained the importance of setting a mutual expectation on the quality of code. He also said the beauty of code review by human’s hand is about reviewing something that machines (like Sider) cannot handle and allowing people to pass their knowledge onto their teammates. So utilizing the Linter tools in your code reviews allow developers to inform the existing rules to new members at every onboarding phase while they judge where they should review manually or have tools do it for you.

The second speaker, Goro Fuji from Bit Journey, Inc., who also goes by as @gfx, talked about Explaining the history: as code

(slide: https://speakerdeck.com/gfx/li-shi-de-jing-wei-falseshuo-ming-as-code ), where he explained how Sider’s original tool Querly works in the process.

In addition to sharing the examples of Querly DSL and use cases of Kibela, Bit Journey’s product, he also explained the difference between the regular Linter tool and Querly. While Linter tools check on standard rules, Querly checks rules that are specific to a particular project and allows users to visualize the history of how the code was written and why. In his talk, gfx also requested Sider to share more use cases from other clients and basic rules. We are really grateful to hear this feedback and we should definitely add this to our to-do list!

Slide says “We want to know more use cases.”

Then, Takeru Yasumoto (@seteen) went on stage to talk about RSpecZ for Easy- to- Review Tests (slide: https://www.slideshare.net/ssuser7aa1e3/code-review-meetup4-rspecz )

The code in RSpec generally tends to be long and hard to review. RSpecZ is a gem that extends RSpec that allows users to write shorter code. Shown as the picture below, when using the RSpecZ, the length of the code in RSpec becomes about a half. This visualization was very much convincing and seemed to have attracted the audience.

Kazuma Watanabe (@wata727),1 an engineer from Sider closed the night with his talk, For a smooth code review (slide: https://speakerdeck.com/wata727/for-a-comfortable-code-review ).

While code reviews serve many purposes, Kazuma focused on problem prevention and sharing knowledge and explained how to do effective reviews to achieve each goal with Phinder, a tool Sider recently released.

Phinder allows users to detect patterns with code smells and remind users if the pattern matches one of the past problems or concerns. It also automatically creates a list of what to check on code reviews.

For sharing knowledge, he suggested writing the experience in YAML files, which resonate with talks by gfx.

After all the sessions are finished, attendees were surrounding the speakers with their questions around the catering table.

Although there are still few code review meetups out there in Tokyo, Sider will continue to build a community of code review as we believe a good code review is really vital for efficient coding or development.

If you are in Tokyo and interested in attending our next Code Review Meetup, please make sure to follow our Connpass or Doorkeeper to get the updates for upcoming events!

***

For more information about Sider, please go to our website.

Leave a Reply

This site uses Akismet to reduce spam. Learn how your comment data is processed.